From Larry.Finger@lwfinger.net Wed Feb 7 07:02:50 2007 Return-Path: Received: from murder ([unix socket]) by ogre.sisk.pl (Cyrus v2.2.12) with LMTPA; Wed, 07 Feb 2007 06:33:47 +0100 X-Sieve: CMU Sieve 2.2 Received: from localhost (localhost.localdomain [127.0.0.1]) by ogre.sisk.pl (Postfix) with ESMTP id 1B89B2BCD6 for ; Wed, 7 Feb 2007 06:33:47 +0100 (CET) Received: from ogre.sisk.pl ([127.0.0.1]) by localhost (ogre.sisk.pl [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 31824-02 for ; Wed, 7 Feb 2007 06:33:46 +0100 (CET) Received: from mail.berlios.de (bat.berlios.de [195.37.77.135]) by ogre.sisk.pl (Postfix) with ESMTP id 7FF7E27389 for ; Wed, 7 Feb 2007 06:33:46 +0100 (CET) Received: from bat.berlios.de (localhost [127.0.0.1]) by mail.berlios.de (Postfix) with ESMTP id 017C4D7EBD; Wed, 7 Feb 2007 07:04:22 +0100 (CET) X-Original-To: bcm43xx-dev@lists.berlios.de Delivered-To: bcm43xx-dev@lists.berlios.de Received: from mtiwmhc11.worldnet.att.net (mtiwmhc11.worldnet.att.net [204.127.131.115]) by mail.berlios.de (Postfix) with ESMTP id 5643CD7EF7 for ; Wed, 7 Feb 2007 07:04:17 +0100 (CET) Received: from [192.168.1.104] (cpe-72-129-173-253.kc.res.rr.com[72.129.173.253]) by worldnet.att.net (mtiwmhc11) with ESMTP id <20070207060251111009mchde>; Wed, 7 Feb 2007 06:02:51 +0000 Message-ID: <45C96B8A.8010000@lwfinger.net> Date: Wed, 07 Feb 2007 00:02:50 -0600 From: Larry Finger User-Agent: Thunderbird 1.5.0.9 (X11/20060911) MIME-Version: 1.0 To: Broadcom Linux , wireless Subject: RFT: The real fix for BCM4311 and BCM4312 X-BeenThere: bcm43xx-dev@lists.berlios.de X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: bcm43xx-dev-bounces@lists.berlios.de Errors-To: bcm43xx-dev-bounces@lists.berlios.de X-Virus-Scanned: amavisd-new at ogre.sisk.pl using MkS_Vir for Linux X-Length: 4138 X-UID: 278239 Status: R X-Status: NC X-KMail-EncryptionState: X-KMail-SignatureState: X-KMail-MDN-Sent: The patch I sent out earlier was wrong; however, it provided a clue as to what was wrong in the specs and in the code. As it turned out, the mistake I made earlier only affected 4 places in the code and it was easy to test them in turn. According to Murphy's law, the wrong one was the last one tested. If you don't know about Murphy, his law can be paraphrased as "Anything that can go wrong will". The patch below will only affect cards with PHY revision 8, which I think are only BCM4311 and BCM4312. At least those are the only ones in the database. Sorry about the false step earlier, but I was so excited to get the 4311 working that I screwed up the test of the 4318. Larry ============== Index: linux-2.6/drivers/net/wireless/bcm43xx/bcm43xx_phy.c =================================================================== --- linux-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_phy.c +++ linux-2.6/drivers/net/wireless/bcm43xx/bcm43xx_phy.c @@ -1225,7 +1225,7 @@ static void bcm43xx_phy_initg(struct bcm } if (phy->rev < 3 && phy->connected) bcm43xx_phy_write(bcm, 0x047E, 0x0078); - if (phy->rev >= 6 && phy->rev <= 8) { + if (phy->rev >= 6 && phy->rev < 8) { bcm43xx_phy_write(bcm, 0x0801, bcm43xx_phy_read(bcm, 0x0801) | 0x0080); bcm43xx_phy_write(bcm, 0x043E, bcm43xx_phy_read(bcm, 0x043E) | 0x0004); } _______________________________________________ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev